Epic/cv2 5050 text vectorization via presto #2112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGaffney
requested review from
amoedoamorim,
brianfleming,
danielevalverde and
sarahkeh
as code owners
…similarity tests]
…take 2 [similarity tests]
caiosba
reviewed
Oct 1, 2024
test/run-tests.sh
Outdated
Comment on lines
13
to
18
| else | ||
| ./parallel-similarity-test.sh | ||
| ./parallel-media-similarity-test.sh | ||
| ./parallel-text-similarity-test.sh |
There was a problem hiding this comment.
Here it should be one or the other depending on whether we're running media similarity tests or text similarity tests.
DGaffney
force-pushed
the
epic/cv2-5050-text-vectorization-via-presto
branch
from
1686c3e
to
a55973f
Compare
Just a refactoring. Two separate builds in CI, one for text and another one for media. --------- Co-authored-by: danielevalverde <[email protected]> Co-authored-by: Caio <[email protected]>
caiosba
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
no-op PR for doing integration tests on check-api changes for alegre/text on presto.
Type of change
How has this been tested?
NA
Things to pay attention to during code review
NA
Checklist
propTypesare declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers