Limit sdp lines (Credit to OSS-Fuzz) #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for an issue discovered by OSS-Fuzz when trying to parse a SDP with a large number of lines.
Long story short, the
g_strsplitfunction is not efficient when dealing with string with a lot of delimiter (\n) occurrences.As a consequence we limit the number of SDP lines to
10000in order to avoid the timeout on OSS-Fuzz and work around the issue in Janus.Of course this is not the optimal solution since we do not want to hardcode a number of lines. In the long term we plan to rewrite the splitting algorithm to avoid such inefficiencies.