PLI dilution for 0.x. Fixes-according-to-PR-3422-remark #3476
Conversation
rtp.c
Outdated
| @@ -1173,8 +1174,8 @@ gboolean janus_rtp_simulcasting_context_process_rtp(janus_rtp_simulcasting_conte | |||
| if(context->substream_target_temp < 0) | |||
| context->substream_target_temp = 0; | |||
| if(context->substream_target_temp != prev_target) { | |||
| JANUS_LOG(LOG_WARN, "No packet received on substream %d for a while, falling back to %d\n", | |||
| context->substream, context->substream_target_temp); | |||
| JANUS_LOG(LOG_WARN, "No packet received on substream %d for %d Milliseconds, falling back to %d\n", | |||
There was a problem hiding this comment.
You may want PRId64 instead of %d here, although Janus currently isn't using this anywhere.
I would've suggested G_GINT64_MODIFIER but:
This is not necessarily the correct modifier for printing and scanning int64_t values, even though the in-memory representation is the same. Standard C macros like PRId64 and SCNd64 should be used for int64_t.
There was a problem hiding this comment.
Our code style is to use %"SCNi64" in those instances (assuming this is a int64_t?).
There was a problem hiding this comment.
Ah ok, that makes since given that internally janus_vprintf is calling g_vasprintf.
|
"Hi, I've fixed it. Please also review the multistream PLI fix; it includes additional changes: #3423." |
|
See #3423 (comment) |
|
Hi @lminiero, thanks for your comments! All fixed and pushed. |
Hi @lminiero,
I had some git issues, so I created this new PR (and branch) for the 0.x patch.
The original PR and our discussion is in : PLI dilution #3422
I've updated the multistream patch in the original PR. Please review. PLI dilution (Multistream) #3423
Thanks