Ignore muted conversations' messages in the notification badge #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @adlk , any follow-up on this? |
|
I can vouch that this is still working well. |
|
Thanks for testing it @venturewise ! I hope it will be merged some day. I know Stefan is really busy. |
|
Hello @adlk, I don't know if this project is still maintained or if this PR still fixes the related bug, so would you mind either merging or closing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you disable notifications for a conversation and receive a message in it, Franz still adds a notification badge. This shouldn't happen as you disabled them.
Motivation and Context
This PR fixes issue #1106 of meetfranz/franz
Types of changes