op-node: parallel events executor #4
Conversation
add metrics and fix data race
claymega
requested review from
yangl1996,
yilongli,
SilasZhr,
Troublor and
bruce-megaeth
claymega
changed the title
| origin eth.L1BlockRef | ||
| resetL2Safe eth.L2BlockRef | ||
| resetSysConfig eth.SystemConfig |
There was a problem hiding this comment.
Should we add mutex for this fields as well? Will they be modified concurrently by multiple goroutines?
There was a problem hiding this comment.
These fields are internal variables and will only be modified by the Step(), but this function will only be called in the pipeline goroutine and not be called by other handler goroutine.
There was a problem hiding this comment.
@claymega I see Reset() function also modify this two variables and Reset() function may also be called by the main event loop. Can you confirm this will not cause a race?
There was a problem hiding this comment.
@claymega I see
Reset()function also modify this two variables andReset()function may also be called by the main event loop. Can you confirm this will not cause a race?
Right, Reset() also modifies these two variables, and I re-check it, Reset() only be called in the pipeline goroutine
* run op-node in parallel-event mode * add metrics and fix data race * delete debug log * delete metrics * recover executor_global_test.go * modify the variable type and function name * modify comment
* run op-node in parallel-event mode * add metrics and fix data race * delete debug log * delete metrics * recover executor_global_test.go * modify the variable type and function name * modify comment
* run op-node in parallel-event mode * add metrics and fix data race * delete debug log * delete metrics * recover executor_global_test.go * modify the variable type and function name * modify comment
该分支源于 op-node: parallel events executor， 使处理event的handler能够并行执行 (event是derivation和sequence逻辑的步骤的抽象概念).
event loop线程和其它handler线程的data race问题解决;