-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vercel guide to cookbooks #2523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a few comments throughout the guide—mostly minor adjustments to bring the text more in line with the rest of the docs (both in tone/style and formatting).
I have one extra recommendation: break down the content after "## Create a Vercel project […]" with extra headings. This will help users navigate the text more easily and give them a way of quickly assess the required steps.
assets/images/vercel/01.create-new-project-on-vercel-dashboard.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I wish we'd say "meilisearch integration" instead of "Meilisearch Cloud integration". It sounds more impactful to me.
Not a big deal though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good except for 1 paragraph to cut down and UTM params to add on links.
I would go for:
utm_campaign=oss
utm_source=docs
utm_medium=vercel-integration
(FYI @curquiza)
Don't forget to add the line in the UTM tracking page in Notion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the extra space :)
All broken links are now fixed, thank you! |
59cc797
to
39496e7
Compare
(Maybe a rebase would fix the broken link. I say maybe because it's a tool we just introduced) |
Current branch add-vercel-guide is up to date. |
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
39496e7
to
5a7b3f0
Compare
Pull Request
Not to be merged before the release of the integration
Related issue
Fixes #2513
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!