-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meilisync MySQL guide #2549
Meilisync MySQL guide #2549
Conversation
All broken links are now fixed, thank you! |
@guimachiavelli, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats @guimachiavelli 🎉
I just put a comment but the rest is great for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few minor comments. overall it looks good to me
Thanks for the feedback, @alallema and @Strift. I have addressed all of it, I believe, including the most important bit regarding Let me know if you spot anything else, otherwise please mark it as approved and I'll deploy it by the end of the day today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me!
Partially addresses #2542
Disclaimer for reviewers: I was not able to successfully install
meilisync
on my machine. I suspect it's related to some python misconfiguration on my end, but it became a huge time drain and I'm working on a short deadline for this. The guide might be rougher than usual because of that.