Meilisync MySQL guide #2549
Merged
Meilisync MySQL guide #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All broken links are now fixed, thank you! |
|
@guimachiavelli, |
alallema
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Congrats @guimachiavelli 🎉
I just put a comment but the rest is great for me
Strift
reviewed
Sep 11, 2023
|
Thanks for the feedback, @alallema and @Strift. I have addressed all of it, I believe, including the most important bit regarding Let me know if you spot anything else, otherwise please mark it as approved and I'll deploy it by the end of the day today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2542
Disclaimer for reviewers: I was not able to successfully install
meilisyncon my machine. I suspect it's related to some python misconfiguration on my end, but it became a huge time drain and I'm working on a short deadline for this. The guide might be rougher than usual because of that.