Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geosearch.mdx #2575

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

LiamKarlMitchell
Copy link
Contributor

@LiamKarlMitchell LiamKarlMitchell commented Oct 1, 2023

Add a note that _geoDistance is only shown if _geo is configured as a displayedAttribute.

Pull Request

Related issue

Fixes #2574

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor Author

@LiamKarlMitchell LiamKarlMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes better worded thanks

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @LiamKarlMitchell!

I made a couple of minor edits to fully integrate your addition with the surrounding text. I applied them immediately, so no action required from you.

Thanks for your contribution! ☺️

@guimachiavelli guimachiavelli merged commit dc11ada into meilisearch:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_geo must be a displayedAttribute to see _geoDistance
2 participants