Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9: distinct search parameter #2885

Merged
merged 10 commits into from
Jun 26, 2024
Merged

v1.9: distinct search parameter #2885

merged 10 commits into from
Jun 26, 2024

Conversation

guimachiavelli
Copy link
Member

Closes #2853

@guimachiavelli guimachiavelli linked an issue Jun 20, 2024 that may be closed by this pull request
1 task
@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.9-distinct-attribute

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review June 24, 2024 13:45
@guimachiavelli guimachiavelli requested a review from a team as a code owner June 24, 2024 13:45
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some precisions, thank you gui 😃

learn/index_settings/distinct.mdx Outdated Show resolved Hide resolved
reference/api/search.mdx Outdated Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for code samples

@guimachiavelli guimachiavelli dismissed Kerollmops’s stale review June 26, 2024 11:05

Applied requested changes verbatim, won't waste reviewer's time with a second request

@guimachiavelli guimachiavelli merged commit c705ed1 into v1.9 Jun 26, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the v1.9-distinct-attribute branch June 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.9: Distinct attributes
4 participants