Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vue quickstart #2891

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Add Vue quickstart #2891

merged 5 commits into from
Jul 9, 2024

Conversation

CaroFG
Copy link
Contributor

@CaroFG CaroFG commented Jun 24, 2024

Pull Request

What does this PR do?

  • Adds Vue quick start
  • Creates the dedicated sidebar route in the frontend section of guides

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:add-vue-quickstart

Credentials to access the page are in the company's password manager as "Docs deploy preview".

Strift
Strift previously approved these changes Jun 25, 2024
guimachiavelli
guimachiavelli previously approved these changes Jul 3, 2024
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, a few minor comments, but looks good to me!

guides/front_end/vue_quick_start.mdx Show resolved Hide resolved
guides/front_end/vue_quick_start.mdx Outdated Show resolved Hide resolved
guides/front_end/vue_quick_start.mdx Outdated Show resolved Hide resolved
@CaroFG CaroFG dismissed stale reviews from guimachiavelli and Strift via 15233e0 July 8, 2024 20:56
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guimachiavelli guimachiavelli merged commit 5cc2121 into main Jul 9, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the add-vue-quickstart branch July 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants