Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update UTM params on vector & hybrid search content #2966

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Sep 3, 2024

I'm updating the UTMs parameters on links to:

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:update-vector-search-utms

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@Strift Strift requested a review from qdequele September 3, 2024 15:21
Copy link
Member

@qdequele qdequele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strift Strift merged commit 0ff2a42 into main Sep 3, 2024
1 of 2 checks passed
@Strift Strift deleted the update-vector-search-utms branch September 3, 2024 15:27
@guimachiavelli
Copy link
Member

guimachiavelli commented Sep 5, 2024

@Strift, please notify me when you merge PRs that don't pass the broken links check. I understand why you ignored the errors, but I got a bit of a scare when I opened a new PR myself just now and got hammered with a bunch of warnings 😅

I'll open a ticket with Notum so they can fix it ASAP, since its usefulness is heavily reduced due to how hard it is to separate false positives from actual errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants