-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move content out of learn/experimental
section
#2979
base: main
Are you sure you want to change the base?
Conversation
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:create-experimental-api-routes Credentials to access the page are in the company's password manager as "Docs deploy preview". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an experimental_ prefix to the following existing code sample ids, without any changes to the samples themselves:
I have to say I'm not pro this change 😞
- a lot of changes on our side to do
- features can be stabilized in a future, and it will be the case of AI, so we will have to change it everywhere again...
Can't you manage your code samples without this change? 🙏 would definitely help us on our side.
@macraig, in short, I'm moving everything out of the experimental section and into places users are more likely to find that info naturally (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new structure looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed with @guimachiavelli and I would rather we don't do this breaking due to the lot of work coming after this breaking for integrations
Oh my bad, as @guimachiavelli 's request for review was after your initial comment @curquiza , I thought you were ok with these changes. |
Apologies, I should have clarified that I intended @macraig's review to be on the content of the PR itself so at least that part has been approved. I'll change the current code samples back to their previous state to reflect in a future commit, once I've dealt with other priorities. |
@meilisearch/integration-team: this PR makes two types of changes to code samples:
experimental_
prefix to the following existing code sample ids, without any changes to the samples themselves:get_embedders_1
->experimental_get_embedders_1
update_embedders_1
->experimental_update_embedders_1
reset_embedders_1
->experimental_reset_embedders_1
search_parameter_guide_hybrid_1
->experimental_search_parameter_guide_hybrid_1
search_parameter_guide_vector_1
->experimental_search_parameter_guide_vector_1
search_parameter_reference_retrieve_vectors_1
->experimental_search_parameter_reference_retrieve_vectors_1
experimental_get_metrics_1
experimental_post_logs_stderr_1
experimental_post_logs_stream_1
experimental_delete_logs_stream_1
This change is mostly for my own internal organization. I do not expect you to supply code samples for any future samples prefixed with
experimental_
, except in strategic cases like AI-powered search.