Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11: Language settings #3018

Merged
merged 1 commit into from
Oct 16, 2024
Merged

v1.11: Language settings #3018

merged 1 commit into from
Oct 16, 2024

Conversation

guimachiavelli
Copy link
Member

Closes #2985

@guimachiavelli guimachiavelli changed the base branch from main to v1.11 October 8, 2024 10:55
@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.11-localization

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review October 8, 2024 11:10
@guimachiavelli guimachiavelli requested a review from a team as a code owner October 8, 2024 11:10
@guimachiavelli guimachiavelli mentioned this pull request Oct 9, 2024
Open
@guimachiavelli
Copy link
Member Author

pinging @ManyTheFish for review

ManyTheFish
ManyTheFish approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guimachiavelli, LGTM, sorry again for the delay!

@guimachiavelli guimachiavelli merged commit 2280e4d into v1.11 Oct 16, 2024
2 checks passed
@guimachiavelli guimachiavelli deleted the v1.11-localization branch October 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.11: Localization setting and parameter now also accept ISO-639-1 bigrams
4 participants
@guimachiavelli @meili-bot @ManyTheFish @curquiza