Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer MEILISEARCH_URL over localhost:7700 #3083

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented Dec 19, 2024

Part of the continuous effort in rendering the docs less focussed on self-hosted instances.

@curquiza, this is the PR we spoke about changing all the target URL for all code samples. I'll only merge it after my return in the new year, so there's no rush as far as SDK code samples go. All changes relevant for the integrations team are in .code-samples.meilisearch.yaml—you can safely ignore the other 19 files touched by this PR.

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:use-meilisearch-url-placeholder

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review December 19, 2024 16:55
@guimachiavelli guimachiavelli requested a review from a team as a code owner December 19, 2024 16:55
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for code samples

@curquiza
Copy link
Member

@guimachiavelli there is git conflict in the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants