Make the Sorter able to sort in parallel
#42
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
parallel-sorter
branch
from
ce29193 to
cfac1c4
Compare
We need to find a way to restrict it a little bit less
Kerollmops
commented
Jul 7, 2023
src/sorter.rs
Outdated
Comment on lines
220
to
222
| match number.get() { | ||
| 1 => ParallelSorter::Single(self.build()), | ||
| number => { |
There was a problem hiding this comment.
We must do number - 1 as if we want only 2 threads we will result in the main sending thread and only one sorter which is useless, lets us keep only the single sorter when the number is equal to 2.
Kerollmops
changed the title
Sorter able to sorter in parallelSorter able to sort in parallel
Kerollmops
force-pushed
the
parallel-sorter
branch
from
76b8a1f to
97896cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I made the
Sorterable to sort in parallel in different ways that I documented:About the multi-sorter solution: TBD.