Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes related to Meilisearch v1.12.0 #307

Closed
37 tasks done
curquiza opened this issue Nov 26, 2024 · 1 comment
Closed
37 tasks done

Changes related to Meilisearch v1.12.0 #307

curquiza opened this issue Nov 26, 2024 · 1 comment
Assignees
@brunoocasali @Strift @curquiza
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

curquiza commented Nov 26, 2024 •
edited
Loading

This issue gathers the changes related to the v1.12.0 of Meilisearch that will impact the integrations scope.

📅 Release date: 2024-12-23

Timelines & steps

Pre-release

  • With the help of the changelog & this CI, define which integrations should be updated and how (New feature? Update README? Update tests?)
    • Fill in the "What to implement?" section below in this issue 👇. Minial implementation: PHP, JS, Instant-meilisearch.
    • Open implementation issues in repositories that need implementation.
    • Discuss with the Product team if needed. At least share this issue to let them know about the decisions.
  • Create a branch by running Octopus script: only open branches for the integrations we choose to update (defined in the previous step) + Kubernetes repository + Cloud provider repository (changing the version)
  • Update integrations according to the decisions (cf "What to implement?" section below in this issue 👇)
    ⚠️ If possible, this step is done before pre-release, once the feature is ready thanks to the prototype released by the engine team
    • JS: opt-out setting, reverse, batch, indices
    • PHP: opt-out setting, reverse, batch, indices
    • Instant-meilisearch: fix tests
    • Ruby: fix tests
  • Add code samples for the chosen up-to-date integrations with the new version of Meilisearch: v1.12: Code sample updates documentation#3065
  • Update the library version of the related integrations and prepare the changelogs
    • JS
    • PHP

Release day

  • Release the integrations or only merged the related PRs (sometimes a release is not needed)
    • JS
    • PHP
    • Instant-meilisearch: ⚠️ update meilisearch-js version ⚠️ before merging and releasing
    • Merge Ruby PR (but no need to release)
  • Merge the related PR in K8s repository
  • Publish DevOps tools:
    • create the git tag
    • publish images (steps are in CONTRIBUTING.md)
  • Remove useless AWS images (by using our internal script)
  • Open issues in the repositories that are not up-to-date with the latest version of Meilisearch (including code samples)

What to implement?

Opt-out settings

Related issue in the engine: meilisearch/meilisearch#4979

Add index settings to customize indexing of users: facetSearch, prefixSearch.

TODO:

Parameter to reverse the order of the task queue

Related issue in the engine: meilisearch/meilisearch#5047

Add a new parameter in GET /tasks route: reverse

TODO:

Give more visibility around batch when indexing

Related issue in the engine:

Changes:

  • The task object gets updated with a new field: batchUid.
  • New routes returning a batch object
    • GET /batches/:uid
    • GET /batches

TODO:

New field in _matchPosition

Related PR: meilisearch/meilisearch#5005

Add a new indices field in the _matchesPosition response.

TODO:

Highlight changes

Related to this PR: meilisearch/meilisearch#4928

The above PR led to changes in highlight behavior (checked internally with the engine team, these are expected). We need to adapt the tests of instant-meilisearch

TODO

AI changes

Related PR: meilisearch/meilisearch#4900

Some tests in some SDKs have to be updated because of breaking changes
@curquiza curquiza added the Meilisearch bump Changes related to the Meilisearch bump version label Nov 26, 2024
This was referenced Nov 26, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@meili-bot meili-bot mentioned this issue Nov 29, 2024
Merged
@curquiza curquiza mentioned this issue Nov 29, 2024
Closed
This was referenced Dec 16, 2024
Closed
Closed
meili-bors bot added a commit to meilisearch/meilisearch-kubernetes that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@curquiza @brunoocasali
Merge #243
45a22f4 
243: Changes related to the next Meilisearch release (v1.12.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#307

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
Co-authored-by: brunoocasali <[email protected]>
meili-bors bot added a commit to meilisearch/meilisearch-js that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@Strift @curquiza @Barabasbalazs @dependabot
Merge #1768
d3593cd 
1768: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#307

This PR:
- gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.12.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Strift <[email protected]>
Co-authored-by: Clémentine <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
Co-authored-by: Balazs Barabas <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/meilisearch-php that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@curquiza @Strift
Merge #692 #705
6515ed6 
692: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#307

This PR:
- gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.12.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


705: Update version for the next release (v1.12.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-php to a new version: "v1.12.0"

CHANGELOGS 👇

This version introduces features released on Meilisearch v1.12.0 🎉

Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information.

## 🚀 Enhancements

- **Addition:** #699

Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. A batch is a set of tasks processed together.

- **Addition:** #698

The `TaskQuery` class now has a `setReverse()` method to retrieve tasks in reverse chronological order.

```php
client->getTasks((new TasksQuery())->setReverse(true));
```

- **Addition:** #702

Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings.

```php
// disable prefix search
$index->updatePrefixSearch('disabled');
// reset prefix search settings
$index->resetPrefixSearch();

// disable facet search
$index->updateFacetSearch(false);
// reset facet search settings
$index->resetFacetSearch();
```

## 🐛 Bug Fixes

- fix: pull the latest in the CI instead of forcing the v1.11 (#691) `@/mdubus`
- Make `hitsCount` always the number of `hits` (and not `totalHits` value) (#701) `@/johnnynotsolucky`

## ⚙️ Maintenance/misc

- Update CI to run with PHP 8.4 (#696) `@/norkunas`
- Fixed SearchNestedFieldsTest test (#704) `@/aivchen`
- PHPStan 2 + fixed uninitialized properties in SearchResult (#706) `@/aivchen`

Thanks again to `@/aivchen,` `@/johnnynotsolucky,` `@/mdubus,` `@/norkunas,` Andrei Ivchenkov, and `@/Strift!` 🎉

Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine <[email protected]>
Co-authored-by: Strift <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
meili-bors bot added a commit to meilisearch/meilisearch-php that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@curquiza @Strift
Merge #692
a55e7c1 
692: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#307

This PR:
- gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.12.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine <[email protected]>
Co-authored-by: Strift <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
meili-bors bot added a commit to meilisearch/meilisearch-ruby that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@dureuill @curquiza
Merge #575
d8facd1 
575: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#307

This PR:
- gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.12.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Louis Dureuil <[email protected]>
Co-authored-by: Clémentine <[email protected]>
meili-bors bot added a commit to meilisearch/meilisearch-php that referenced this issue Dec 23, 2024
@meili-bors @meili-bot
@curquiza @Strift
Merge #692
78879c2 
692: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#307

This PR:
- gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.12.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine <[email protected]>
Co-authored-by: Strift <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>
This was referenced Dec 27, 2024
Open
Open
Open
This was referenced Dec 31, 2024
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
@curquiza
Copy link
Member Author

Closing the issue, everything is dooooone 😁
Thank you everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunoocasali brunoocasali

@Strift Strift

@curquiza curquiza

Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunoocasali @Strift @curquiza