Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.12.0] Adapt tests to new Meilisearch highlight behavior #1340

Closed
1 task
curquiza opened this issue Nov 28, 2024 · 3 comments · Fixed by #1341
Closed
1 task

[v1.12.0] Adapt tests to new Meilisearch highlight behavior #1340

curquiza opened this issue Nov 28, 2024 · 3 comments · Fixed by #1341
Assignees

Comments

@curquiza
Copy link
Member

Related to meilisearch/integration-guides#307

Explanation of the feature

Related to this PR: meilisearch/meilisearch#4928

The above PR led to changes in highlight behavior (checked internally with the engine team, these are expected). We need to adapt the tests of instant-meilisearch

TODO

  • Adapt the breaking test to the new Meilisearch behavior

⚠️ Make PRs pointing to bump-meilisearch-v1.12.0 and NOT main. Please do 1 PR for all of these changes, and not several.

@curquiza
Copy link
Member Author

curquiza commented Dec 9, 2024

@Strift I merged #1341
but tests are still failing in #1339 Pre-Release Tests / instant-meilisearch end-to-end-tests
so I don't close this issue yet

@Strift
Copy link
Collaborator

Strift commented Dec 12, 2024

Yes, I've requested assistance from @ManyTheFish to investigate why this test might fail. It's related to searching facet values, so these tests should not be failing as far as I understand.

@curquiza
Copy link
Member Author

This test is now fixed with rc6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants