-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement experimental ai-powered search #398
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
51d76fc
implement experimental ai-powered search
memishood b214ea2
Fix openAiKey for unit tests not working for flutter web
memishood 3a51c8b
Map the source field only once in the base embedder class
memishood 6fc1e47
Return unknown embedder instead of exception when the source is not h…
memishood 9c2dd85
Create static source variables for each embedder
memishood a3d03d3
update semantic ratio assert
memishood 47cd6c0
Merge remote-tracking branch 'origin/main' into pr/memishood/398
ahmednfwela 80421da
Merge branch 'main' into feat/embedders
memishood b7f7e2a
Comment embedders unit tests
memishood 0808f83
Merge branch 'feat/embedders' of https://github.com/phosum/meilisearc…
ahmednfwela 49699f2
fixes and improvements
ahmednfwela 5a9144f
Merge pull request #1 from ahmednfwela/pr/memishood/398
memishood d728b29
Update test/search_test.dart
memishood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
class HybridSearch { | ||
final String embedder; | ||
final double semanticRatio; | ||
|
||
const HybridSearch({ | ||
required this.embedder, | ||
required this.semanticRatio, | ||
}) : assert( | ||
semanticRatio >= 0.0 && semanticRatio <= 1.0, | ||
"'semanticRatio' must be between 0.0 and 1.0", | ||
); | ||
|
||
Map<String, Object?> toMap() => { | ||
'embedder': embedder, | ||
'semanticRatio': semanticRatio, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
class Distribution { | ||
final double mean; | ||
final double sigma; | ||
|
||
Distribution({ | ||
required this.mean, | ||
required this.sigma, | ||
}); | ||
|
||
factory Distribution.fromMap(Map<String, Object?> map) { | ||
return Distribution( | ||
mean: map['mean'] as double, | ||
sigma: map['sigma'] as double, | ||
); | ||
} | ||
|
||
Map<String, Object?> toMap() => { | ||
'mean': mean, | ||
'sigma': sigma, | ||
}; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is used in query parameters, it should automatically exclude null values (as per meilisearch conventions), the logic for this is already present in
Queryable
class, so it can be uesd.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Distribution isn't used in the query parameters; it is a field of some embedders, and the fields in this class aren't actually nullable.