Merge #609

609: Possible fix to release issue r=curquiza a=danFbach


# Pull Request

## Related issue
Fixes #605 

## What does this PR do?
- **removes unused System.Globalization using.** this may be the fix for the issue - this is more/less a guess since i can't test the publish on my end.
- while reviewing this file, i noticed that the type matching could be accomplished more easily by using built-in pattern type matching instead of reflection based type matching, also making code more readable. All tests passed.

Hope this helps!

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?



Co-authored-by: Dan Fehrenbach <[email protected]>

src/Meilisearch/Extensions/ObjectExtensions.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.Linq;
 using System.Reflection;
 
@@ -43,31 +42,25 @@ internal static string ToQueryString(this object source, BindingFlags bindingAtt
 
                     if (value != null)
                     {
-                        var type = value.GetType();
-
-                        if (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(List<>))
+                        if (value is List<string> stringValue)
+                        {
+                            values.Add(key + "=" + string.Join(",", stringValue));
+                        }
+                        else if (value is List<int> intValue)
+                        {
+                            values.Add(key + "=" + string.Join(",", intValue));
+                        }
+                        else if (value is List<TaskInfoStatus> taskInfoStatusValue)
+                        {
+                            values.Add(key + "=" + string.Join(",", taskInfoStatusValue.Select(x => x.ToString())));
+                        }
+                        else if (value is List<TaskInfoType> taskInfoTypeValue)
                         {
-                            var itemType = type.GetGenericArguments()[0];
-                            if (itemType == typeof(string))
-                            {
-                                values.Add(key + "=" + string.Join(",", (List<string>)value));
-                            }
-                            else if (itemType == typeof(int))
-                            {
-                                values.Add(key + "=" + string.Join(",", (List<int>)value));
-                            }
-                            else if (itemType == typeof(TaskInfoStatus))
-                            {
-                                values.Add(key + "=" + string.Join(",", ((List<TaskInfoStatus>)value).Select(x => x.ToString())));
-                            }
-                            else if (itemType == typeof(TaskInfoType))
-                            {
-                                values.Add(key + "=" + string.Join(",", ((List<TaskInfoType>)value).Select(x => x.ToString())));
-                            }
+                            values.Add(key + "=" + string.Join(",", taskInfoTypeValue.Select(x => x.ToString())));
                         }
-                        else if (value is DateTime)
+                        else if (value is DateTime datetimeValue)
                         {
-                            values.Add(key + "=" + Uri.EscapeDataString(((DateTime)value).ToString("yyyy-MM-dd'T'HH:mm:ss.fffzzz")));
+                            values.Add(key + "=" + Uri.EscapeDataString(datetimeValue.ToString("yyyy-MM-dd'T'HH:mm:ss.fffzzz")));
                         }
                         else
                         {

tests/Meilisearch.Tests/ObjectExtensionsTests.cs

@@ -1,9 +1,6 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text.Json.Serialization;
 
-using Meilisearch.Converters;
 using Meilisearch.Extensions;
 using Meilisearch.QueryParameters;