SortFacetValuesBy support #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danFbach
force-pushed
the
sort-facets-value-460
branch
from
7473027 to
5bde104
Compare
curquiza
requested changes
Jan 8, 2025
| }; | ||
| await client.Index("INDEX_NAME").SearchAsync<T>("badman", params); | ||
| get_dictionary_1: |- |
There was a problem hiding this comment.
@danFbach why did you remove the dictionary code samples?
There was a problem hiding this comment.
might have been working with an outdated example file when i made this pr
|
Merge conflict. |
|
bors merge |
|
Already running a review |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #460
What does this PR do?
-implements sort facets feature
PR checklist
Please check if your PR fulfills the following requirements:
let me know if i missed anything.