Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searchCutoffMs setting support #594

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add searchCutoffMs setting support #594

merged 3 commits into from
Jan 8, 2025

Conversation

danFbach
Copy link
Contributor

Pull Request

Related issue

Fixes #536

What does this PR do?

  • implements searchCutoffMs

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@danFbach
Copy link
Contributor Author

the changes to .csproj are mostly whitespace and adding my new partial index class as a child of the Index.cs

@curquiza curquiza added the enhancement New feature or request label Jan 8, 2025
curquiza
curquiza previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 8, 2025

Merge conflict.

@curquiza curquiza changed the title implement searchCutoffMs 536 Add searchCutoffMs setting support Jan 8, 2025
curquiza
curquiza previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 8, 2025

Merge conflict.

curquiza
curquiza approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 8, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 81fd8a3 into meilisearch:main Jan 8, 2025
4 checks passed
@danFbach danFbach deleted the support-searchCutoffMs-536 branch January 8, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.8] Support searchCutoffMs setting
2 participants
@danFbach @curquiza