Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.11.0] Make the embedder mandatory everywhere #583

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[v1.11.0] Make the embedder mandatory everywhere #583

merged 1 commit into from
Oct 9, 2024

Conversation

Kerollmops
Copy link
Member

Pull Request

Related issue

Fixes #578

What does this PR do?

  • Makes the hybrid.embedder field mandatory everywhere.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Kerollmops Kerollmops marked this pull request as ready for review October 9, 2024 08:20
curquiza
curquiza approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchas gracias

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Oct 9, 2024
@curquiza curquiza merged commit e031aaa into bump-meilisearch-v1.11.0 Oct 9, 2024
4 checks passed
@curquiza curquiza deleted the fix-ai-powered-search branch October 9, 2024 09:02
@curquiza curquiza added enhancement New feature or request breaking-change The related changes are breaking for the users and removed maintenance Anything related to maintenance (CI, tests, refactoring...) enhancement New feature or request labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerollmops @curquiza