Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interface pollution #589

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Nov 6, 2024

Pull Request

What does this PR do?

  • This PR fix interface pollution in service and index manager and don't have break changes.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad requested a review from curquiza November 6, 2024 07:34
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.23%. Comparing base (67bcf69) to head (eb62ceb).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
index_task.go 94.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   85.58%   86.23%   +0.65%     
==========================================
  Files          13       14       +1     
  Lines        2802     2826      +24     
==========================================
+ Hits         2398     2437      +39     
+ Misses        292      280      -12     
+ Partials      112      109       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 6, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Nov 6, 2024

@meili-bors meili-bors bot merged commit 0bf60fa into meilisearch:main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants