Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance encoding algorithm and improve naming convention #594

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Dec 25, 2024

What does this PR do?

  • Fix return buffers to the pool after use
  • Add encoding and decoding benchmark
  • Improve naming convention

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad requested a review from curquiza December 25, 2024 08:07
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (6f83ef3) to head (12e4658).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   86.21%   86.22%           
=======================================
  Files          14       14           
  Lines        2843     2845    +2     
=======================================
+ Hits         2451     2453    +2     
  Misses        282      282           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant