Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AI-powered search changes for v1.11 #1742

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: AI-powered search changes for v1.11 #1742

merged 1 commit into from
Oct 10, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Oct 9, 2024 •
edited
Loading

Pull Request

Related issue

Fixes #1714

What does this PR do?

  • Moved the AI-search-related tests to the embedders test file for easier maintenance
  • Adapt types related to AI-search:
    • embedder is now mandatory for GET and POST searches
    • Addition of documentTemplateMaxBytes (except for userProvided embedders)
    • Addition of binaryQuantized
  • Update snapshots (documentTemplate has been updated)
  • Update tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus marked this pull request as ready for review October 9, 2024 13:24
@mdubus mdubus requested a review from curquiza October 9, 2024 13:24
curquiza
curquiza approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci momo !!

@curquiza curquiza merged commit 4662933 into bump-meilisearch-v1.11.0 Oct 10, 2024
6 checks passed
@curquiza curquiza deleted the feat/ai_powered_search_changes_v1.11 branch October 10, 2024 08:46
@curquiza curquiza mentioned this pull request Oct 10, 2024
Closed
6 tasks
@mdubus mdubus added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @curquiza