Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default to unset storageclass #235

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

acelinkio
Copy link
Contributor

Pull Request

Related issue

N/A

What does this PR do?

  • Sets the default storageClass value to align with documentation beside it. Requires one less variable be defined for a quick setup.

PR checklist

Please check if your PR fulfills the following requirements:

  • [X ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@acelinkio acelinkio changed the title change defaul to unset storageclass change default to unset storageclass Jul 10, 2024
@brunoocasali
Copy link
Member

@meilisearch sync-manifest

@brunoocasali
Copy link
Member

I was not aware of the ~ tilde usage in YML, it means null right?

And I think the change makes sense as well

@acelinkio
Copy link
Contributor Author

correct. ~ is shorthand for null. link to yaml source http://yaml.org/spec/1.2/spec.html#id2805071

@acelinkio
Copy link
Contributor Author

I see the tests failed. Looks like it expects a version to be bumped. I am down to increment it, but figured that would be best to a release process.

@brunoocasali
Copy link
Member

Hi @acelinkio can you update the chart version? So I can merge this PR?

@brunoocasali brunoocasali added the enhancement New feature or request label Aug 7, 2024
@acelinkio
Copy link
Contributor Author

Updated version to 0.9.1

@brunoocasali
Copy link
Member

@meilisearch sync-manifest

@brunoocasali
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Aug 21, 2024

Build succeeded:

@acelinkio acelinkio closed this Aug 21, 2024
@meili-bors meili-bors bot merged commit bec4311 into meilisearch:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants