Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code samples for v1.4.0 #579

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Sep 13, 2023

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Sep 13, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a bad naming hanging around

.code-samples.meilisearch.yaml Show resolved Hide resolved
.code-samples.meilisearch.yaml Show resolved Hide resolved
.code-samples.meilisearch.yaml Show resolved Hide resolved
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@brunoocasali
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Sep 14, 2023
579: Add code samples for v1.4.0 r=brunoocasali a=curquiza

Related to meilisearch/documentation#2556

Co-authored-by: curquiza <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 14, 2023

Build failed:

@curquiza
Copy link
Member Author

bors merge

meili-bors bot added a commit that referenced this pull request Sep 18, 2023
579: Add code samples for v1.4.0 r=curquiza a=curquiza

Related to meilisearch/documentation#2556

Co-authored-by: curquiza <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 18, 2023

Build failed:

@curquiza
Copy link
Member Author

Oh course it cannot work with the updated test...
merging manually

@curquiza curquiza merged commit 3c3a450 into bump-meilisearch-v1.4.0 Sep 18, 2023
10 of 11 checks passed
@curquiza curquiza deleted the code-samples-v1.4 branch September 18, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants