Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports rankingScoreThreshold search parameter #1008

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Supports rankingScoreThreshold search parameter #1008

merged 5 commits into from
Aug 26, 2024

Conversation

aweidner
Copy link
Contributor

Pull Request

Related issue

Fixes #986

What does this PR do?

  • Adds an integration test for a search using rankingScoreThreshold
  • Updates the code example file to include a translated call for search involving rankingScoreThreshold

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the enhancement New feature or request label Aug 26, 2024
sanders41
sanders41 requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is just wanting an empty line at the end of the files.

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
datasets/small_movies.json Outdated Show resolved Hide resolved
sanders41
sanders41 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aweidner

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Aug 26, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 7dbade5 into meilisearch:main Aug 26, 2024
11 checks passed
@curquiza curquiza mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.9] Support rankingScoreThreshold search parameter
2 participants
@aweidner @sanders41