Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backward compatible with Meilisearch < v1.11.0 #1021

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

#1020 will make the package not backwards compatible with Meilisearch < 1.11 because of the new embedder field. I was thinking about this and we can make a change to keep backwards compatibility.

@dureuill, embedders are somewhat hard to test here because they cause the test suite to time out so I want to see if you can verify my assumption. Sending the embedder to v1.11 with no documentTemplateMaxBytes will have the same effect as sending it will a null value, i.e. causing it to fall back to the default value, correct?

Related issue

Fixes #<issue_number>

What does this PR do?

  • If an embedder contains a contains documentTemplateMaxBytes and the value is None remove it before sending to Meilisearch.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@dureuill
Copy link

@dureuill, embedders are somewhat hard to test here because they cause the test suite to time out so I want to see if you can verify my assumption. Sending the embedder to v1.11 with no documentTemplateMaxBytes will have the same effect as sending it will a null value, i.e. causing it to fall back to the default value, correct?

yes that's correct :-) documentTemplateMaxBytes is optional in v1.11, defaulting to its default value if not provided

@curquiza curquiza requested review from dureuill and removed request for curquiza September 30, 2024 15:53
Copy link

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanders41 sanders41 merged commit 691c622 into bump-meilisearch-v1.11.0 Sep 30, 2024
10 checks passed
@sanders41 sanders41 deleted the embedder-backwards-compatible branch September 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants