Make backward compatible with Meilisearch < v1.11.0 #1021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
#1020 will make the package not backwards compatible with Meilisearch < 1.11 because of the new embedder field. I was thinking about this and we can make a change to keep backwards compatibility.
@dureuill, embedders are somewhat hard to test here because they cause the test suite to time out so I want to see if you can verify my assumption. Sending the embedder to v1.11 with no
documentTemplateMaxBytes
will have the same effect as sending it will a null value, i.e. causing it to fall back to the default value, correct?Related issue
Fixes #<issue_number>
What does this PR do?
documentTemplateMaxBytes
and the value isNone
remove it before sending to Meilisearch.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!