Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor meilisearch.rb #348

Open
11 tasks
ellnix opened this issue Feb 29, 2024 · 0 comments
Open
11 tasks

Refactor meilisearch.rb #348

ellnix opened this issue Feb 29, 2024 · 0 comments
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Milestone
0.13

Comments

@ellnix
Copy link
Collaborator

ellnix commented Feb 29, 2024

  • Streamline interface
    • remove similarly named instance and class methods where one often just calls the other
    • reduce method side effects
    • reduce hacks in methods
    • clarify bang method API
    • do not use flag parameters (i. e. product.index!(true))
    • make return types more consistent
  • Reach 95%+ code coverage
  • More robust error reporting (no failing silently)
  • Break meilisearch.rb into multiple files/modules
  • Add a system for validating configurations
@ellnix ellnix added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Feb 29, 2024
@ellnix ellnix added this to the 0.13 milestone Feb 29, 2024
@ellnix ellnix mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
1 participant
@ellnix