Update dependencies

[omid]

Update dependencies and a bit of housekeeping.

[omid]

There is a typo in Cancelation (like in TaskCancelation), but it's also like this in the app itself, so it's bigger than the sdk and most probably a breaking change!

[curquiza]

Hello @omid
thanks for the PR

We are ok with breaking changes since the app is not stable (using version format like v0.X.Y and not vX.Y.Z), so we can accept a PR. The most important is to be clear in the communication

[curquiza]

Also @omid you said you updated the dependencies but you also changed a lot of things

I would rather we separate the typo fixes and the dependencies updates/code changes that are not related to typos please 😊 I appreciate the work, but it's not really convenient to review and I don't feel comfortable accepting a PR where I have that much files to review for different reasons

[omid]

@curquiza Thanks 🙏🏼

Also @omid you said you updated the dependencies but you also changed a lot of things

I updated syn to 2, jsonwebtoken to 9, and removed env_logger, since it wasn't in use.

I don't feel comfortable accepting a PR where I have that much files to review for different reasons

If you don't mind, the update dep thingy changes are in just one commit which you can find here.

We are ok with breaking changes since the app is not stable (using version format like v0.X.Y and not vX.Y.Z), so we can accept a PR. The most important is to be clear in the communication

Sure, the only issue will be that the change should be applied everywhere! Including all SDKs I think, which I'm not familiar with their languages and it's a big chunk of work also. (github said 50 files in the meilisearch org)

[curquiza]

If you don't mind, the update dep thingy changes are in just one commit which you can find here.

Not 100% true, this commit also change some parts of the code at the middle of the non-code related update:
3516519

I really would rather you separate your changes, so your PRs, please. For our convenience. We have a lot of things to review, and not a lot of time, it will really help us 🙏

[curquiza]

Sure, the only issue will be that the change should be applied everywhere! Including all SDKs I think, which I'm not familiar with their languages and it's a big chunk of work also. (github said 50 files in the meilisearch org)

Can you point which kind of change you refer and why the issue is in all the SDKs?

[omid]

Can you point which kind of change you refer and why the issue is in all the SDKs?

As I said in the first post here, There is a typo in *Cancelation*. It's wrong, it's cancellation, double LL.

[omid]

Not 100% true, this commit also change some parts of the code at the middle of the non-code related update:

The update deps are in one commit. Others are typos and some housekeeping. There are some changes in the macro part in other commits, but they are not about the logic. Just code style, typo and so on.

[curquiza]

Can you fix git conflicts?

[irevoire]

Hey @omid thanks for your contribution it’s very nice, and updating syn was not an easy task!

We’re very grateful you did it; however, if you do it again, please follow curqui advice.
Do one PR that only updates the dependencies and another that only fixes typos.
That will make it way easier for us to review and merge (that’s also why I took so long to get back to you)

bors merge

[irevoire]

That’s pretty nice, didn’t know about it before

[meili-bors]

Build succeeded:

• clippy-check
• integration-tests
• readme-check
• rust-format
• wasm-build
• Yaml linting check