Skip to content

Commit

Permalink
Merge #267
Browse files Browse the repository at this point in the history
267: Require explicitly the PHP v8 polyfill r=norkunas a=94noni

# Pull Request

as the class `MeilisearchExtension` calls `str_starts_with` ([doc](https://www.php.net/manual/en/function.str-starts-with.php))
This polyfill must be required explicitly imho (not via transient deps)

obviously feel free to close, spotted while checking codebases related to this issue #263

Co-authored-by: Antoine Makdessi <[email protected]>
  • Loading branch information
meili-bors[bot] and 94noni authored Jul 13, 2023
2 parents ad92065 + 207629d commit 488b1cd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"doctrine/doctrine-bundle": "^2.4",
"meilisearch/meilisearch-php": "^1.0.0",
"symfony/filesystem": "^4.4 || ^5.0 || ^6.0",
"symfony/polyfill-php80": "^1.27",
"symfony/property-access": "^4.4 || ^5.0 || ^6.0",
"symfony/serializer": "^4.4 || ^5.0 || ^6.0"
},
Expand Down

0 comments on commit 488b1cd

Please sign in to comment.