Leverage new symfony command name and description definition

meilisearch · Jun 25, 2023 · 8e5edd3 · 8e5edd3
1 parent 5dbe03b
commit 8e5edd3
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 61 deletions.
diff --git a/composer.json b/composer.json
@@ -39,7 +39,6 @@
     "phpstan/phpstan-phpunit": "^1.3.10",
     "phpstan/phpstan-symfony": "^1.2.23",
     "phpunit/php-code-coverage": "^9.2.26",
-    "rector/rector": "^0.17.1",
     "symfony/doctrine-bridge": "^5.4 || ^6.0",
     "symfony/http-client": "^5.4 || ^6.0",
     "symfony/phpunit-bridge": "^5.4 || ^6.0",

diff --git a/rector.php b/rector.php
diff --git a/src/Command/MeilisearchClearCommand.php b/src/Command/MeilisearchClearCommand.php
@@ -14,20 +14,12 @@
  */
 final class MeilisearchClearCommand extends IndexCommand
 {
-    public static function getDefaultName(): string
-    {
-        return 'meili:clear';
-    }
-
-    public static function getDefaultDescription(): string
-    {
-        return 'Clear the index documents';
-    }
+    protected static $defaultName = 'meili:clear';
+    protected static $defaultDescription = 'Clear the index documents';
 
     protected function configure(): void
     {
-        $this
-            ->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
+        $this->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int

diff --git a/src/Command/MeilisearchCreateCommand.php b/src/Command/MeilisearchCreateCommand.php
@@ -20,27 +20,19 @@ final class MeilisearchCreateCommand extends IndexCommand
 {
     private Client $searchClient;
 
+    protected static $defaultName = 'meili:create';
+    protected static $defaultDescription = 'Create indexes';
+
     public function __construct(SearchService $searchService, Client $searchClient)
     {
         parent::__construct($searchService);
 
         $this->searchClient = $searchClient;
     }
 
-    public static function getDefaultName(): string
-    {
-        return 'meili:create';
-    }
-
-    public static function getDefaultDescription(): string
-    {
-        return 'Create indexes';
-    }
-
     protected function configure(): void
     {
-        $this
-            ->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
+        $this->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
     }
 
     private function entitiesToIndex($indexes): array

diff --git a/src/Command/MeilisearchDeleteCommand.php b/src/Command/MeilisearchDeleteCommand.php
@@ -16,20 +16,13 @@
  */
 final class MeilisearchDeleteCommand extends IndexCommand
 {
-    public static function getDefaultName(): string
-    {
-        return 'meili:delete';
-    }
 
-    public static function getDefaultDescription(): string
-    {
-        return 'Delete the indexes';
-    }
+    protected static $defaultName = 'meili:delete';
+    protected static $defaultDescription = 'Delete the indexes';
 
     protected function configure(): void
     {
-        $this
-            ->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
+        $this->addOption('indices', 'i', InputOption::VALUE_OPTIONAL, 'Comma-separated list of index names');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int

diff --git a/src/Command/MeilisearchImportCommand.php b/src/Command/MeilisearchImportCommand.php
@@ -25,6 +25,9 @@ final class MeilisearchImportCommand extends IndexCommand
 {
     private const DEFAULT_RESPONSE_TIMEOUT = 5000;
 
+    protected static $defaultName = 'meili:import';
+    protected static $defaultDescription = 'Import given entity into search engine';
+
     protected Client $searchClient;
     protected ManagerRegistry $managerRegistry;
 
@@ -36,16 +39,6 @@ public function __construct(SearchService $searchService, ManagerRegistry $manag
         $this->searchClient = $searchClient;
     }
 
-    public static function getDefaultName(): string
-    {
-        return 'meili:import';
-    }
-
-    public static function getDefaultDescription(): string
-    {
-        return 'Import given entity into search engine';
-    }
-
     protected function configure(): void
     {
         $this