Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meilisearch: prefix for commands #289

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Use meilisearch: prefix for commands #289

merged 1 commit into from
Sep 1, 2023

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #280

What does this PR do?

  • Replaces meili:* prefixes in command names to meilisearch:* while making meili:* prefix as command aliases which maybe later could be deprecated

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

brunoocasali
brunoocasali approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunoocasali
Copy link
Member

@norkunas Can we introduce an alert or something to let the users know about the deprecation?

@norkunas
Copy link
Collaborator Author

norkunas commented Aug 30, 2023 •
edited
Loading

@norkunas Can we introduce an alert or something to let the users know about the deprecation?

I'm not sure how to do that 😞 will see. With this PR meilisearch:* and meili:* works so we can merge now and add deprecation later if possible

@brunoocasali
Copy link
Member

Perfect for me @norkunas let's do it!

@norkunas
Copy link
Collaborator Author

norkunas commented Sep 1, 2023

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 1, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit ae11954 into meilisearch:main Sep 1, 2023
6 checks passed
@norkunas norkunas deleted the commands branch September 1, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands should use meilisearch: prefix instead of meili:
2 participants
@norkunas @brunoocasali