Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new dropdown for rendering large list #458

Merged

Conversation

vaibhav135
Copy link
Contributor

Pull Request

Related issue

Fixes #167

What does this PR do?

  • This PR fixes the issue where if you load a lot of datasets ( > 1000 ) the dropdown starts to lag and UX becomes super laggy.

Here's the before and after -

before
https://github.com/meilisearch/mini-dashboard/assets/39329182/e72f45d7-f143-460e-afe3-e3858e03fc9d

after
https://github.com/meilisearch/mini-dashboard/assets/39329182/bc7f94fb-764c-4a9f-b306-6a6890e2e1a2

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@bidoubiwa
Copy link
Contributor

Amazong @vaibhav135 I'll be reviewing this asap :) Any idea why the cypress test is failing?

@vaibhav135
Copy link
Contributor Author

Amazong @vaibhav135 I'll be reviewing this asap :) Any idea why the cypress test is failing?

@bidoubiwa I will check it.

@vaibhav135
Copy link
Contributor Author

@bidoubiwa I have fixed all the tests. Also I saw that in a lot of places we were picking the element for e.g.ul directly. Please don't do that moving forward, because that is considered as a bad practise, check here for more details. Please try to use data-cy, data-testid or data-id for getting an element.

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! ✨

Thanks for this information! :) We'll take that into account in the future.

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 25, 2023

@meili-bors meili-bors bot merged commit 6b069df into meilisearch:main Jul 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slowness during the display
2 participants