Simplify the way to get npm package version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
reviewed
Jul 31, 2023
| @@ -10,7 +9,7 @@ export function initMeilisearchClient({ | |||
| host, | |||
| apiKey, | |||
| clientAgents: [ | |||
| `Meilisearch Crawler (v${PACKAGE_VERSION})`, | |||
| `Meilisearch Crawler (v${process.env.npm_package_version})`, | |||
There was a problem hiding this comment.
How is the version added in the env variable npm_package_version ?
There was a problem hiding this comment.
It's npm that is adding it by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple contribution uses the environment variable to get the npm package version instead of updating manually the version on a file.
Not sure if it's working on Docker but it should as we are performing a npm run start and not a node index.js from a transpiled file.