Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increases timeout to avoid MeiliSearchTimeOutError when using auto-embeddings #92

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Increases timeout to avoid MeiliSearchTimeOutError when using auto-embeddings #92

merged 1 commit into from
Jan 31, 2024

Conversation

CaroFG
Copy link
Contributor

@CaroFG CaroFG commented Jan 22, 2024

Pull Request

Related issue

Fixes #91

What does this PR do?

  • Increases waitForTask timeout in __batchSendSync()

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@CaroFG CaroFG marked this pull request as ready for review January 22, 2024 16:51
tpayet
tpayet approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@tpayet tpayet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

@tpayet tpayet merged commit 6140261 into main Jan 31, 2024
5 checks passed
@tpayet tpayet deleted the increase-timeout branch January 31, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpayet tpayet tpayet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meilisearch throws a timeout error when indexing with auto-embeddings
2 participants
@CaroFG @tpayet