feat: support (OCaml syntax) expressions in {j| .. |j} interpolation
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
reviewed
Jan 10, 2024
| @@ -167,15 +167,6 @@ let suites = | |||
| ] ); | |||
| ( __LOC__ >:: fun _ -> | |||
| {|$x)|} ==* [ (0, 0, 0, 2, var, "x"); (0, 2, 0, 3, String, ")") ] ); | |||
| ( __LOC__ >:: fun _ -> | |||
There was a problem hiding this comment.
I wonder if these tests can be left, but updating them to the new behavior?
There was a problem hiding this comment.
The new behavior is different and it's covered elsewhere, in the blackbox-tests. I think these are actually unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{j| .. |j}interpolation #1024$( .. )interpolation in{j| .. |j}, not just identifiersstill not sure if this is a good idea because it won't be able to support Reason syntax. Feedback welcome