Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more instructions to PR exercise #198

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Add more instructions to PR exercise #198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11da1b4
Add more instructions to PR exercise
vinisalazar Oct 14, 2024
27c6993
Add uncheck box instruction
vinisalazar Oct 14, 2024
7c497c0
Remove instruciton added in previous commit
vinisalazar Oct 14, 2024
a037c3c
Merge branch 'master' of github.com:melbournebioinformatics/MelBioInf…
vinisalazar Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/tutorials/git/git.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,9 +951,10 @@ If you have your project available on GitHub, it is likely that you will have to
Because of that, let's practice **reviewing** a pull request, that is, the scenario where someone would submit a pull request to our repository.

???+ question "Reviewing a pull request"
1. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork.
2. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository.
3. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button:**
1. Create a new branch called `add-name` using the following command: `git checkout -b add-name`.
2. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork, using the following command: `git push --set-upstream origin add-name`
3. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository.
4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch.

![](./media/PR_base_repository.png)

Expand Down