Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PropTypes usage with deprecated-react-native-prop-types #1004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ingointo
Copy link

@ingointo ingointo commented Jan 18, 2024

Platforms affected

None, this PR addresses a deprecation warning related to the use of PropTypes.

What does this PR do?

This PR updates the codebase to replace the usage of PropTypes with the deprecated-react-native-prop-types package. The goal is to resolve the deprecation warning related to ViewPropTypes and align with the recommended migration away from PropTypes in React Native.

What testing has been done on this change?

This change has been tested locally to ensure that the deprecation warning no longer occurs. Additionally, the application has been tested to verify that the functionality of the react-native-snap-carousel library remains unaffected.

Tested features checklist

Additional Notes

Ensure that the changes do not introduce any regressions and that the library's features remain fully functional.

This PR is in response to the deprecation warning mentioned here. The replacement of PropTypes is a step toward compatibility with the evolving standards in React Native.

Please review and provide feedback. Thank you!

@ingointo
Copy link
Author

hey..

@MaiconLeffa
Copy link

hi, some news about this PR?

@ingointo
Copy link
Author

ingointo commented Feb 24, 2024

hi, some news about this PR?

Hello MaiconLeffa, I appreciate your patience. I've thoroughly tested the changes and addressed any feedback received. The pull request is still in progress, and I'll continue to keep you updated on any further developments. Please feel free to reach out if you have any specific questions or concerns. Thank you once again for your interest and support!

@ingointo ingointo closed this Feb 24, 2024
@ingointo ingointo reopened this Feb 24, 2024
@leozhang007
Copy link

hello,When will the merger begin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants