Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewPropTypes has been removed from React Native #962

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shakeel0581
Copy link

Platforms affected

ViewPropTypes has been removed from React Native.

What does this PR do?

Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.

What testing has been done on this change?

Tested features checklist

Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
I have added new package deprecated-react-native-prop-types
@samih-sghier
Copy link

can this be merged/deployed?

@yousrasd
Copy link

yousrasd commented Nov 29, 2022

Please, can we merge this branch and include it in an official release? We are dependent on this lib in our project, and we can't proceed with the upgrade to ReactNative 0.70 due to this ViewPropTypes dependency.

Copy link

@MHF0 MHF0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a new version for deprecated-react-native-prop-types you can change it to the new version

    "deprecated-react-native-prop-types": "^3.0.1",

@LG1710
Copy link

LG1710 commented Jan 13, 2023

Hello, could you merge this PR in the master and make a new tagged version, thx

@romchambe
Copy link

romchambe commented Jan 30, 2023

👍 to merge this PR and publish a new version 🙏 This is completely blocking for RN 0.69

@interstates21
Copy link

Why it's still not merged?

Copy link

@diogobas diogobas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogobas
Copy link

@meliorence please, merge it when you get a chance.

@batazo
Copy link

batazo commented Mar 23, 2023

Use React Native New Snap Carousel
https://www.npmjs.com/package/react-native-new-snap-carousel
https://github.com/bzozoo/react-native-new-snap-carousel

@tendaimaswaya
Copy link

It might be safe to say there's no future for this current package. It seems to have taken eons to merge and publish something that's already been implemented.

Copy link

@MHF0 MHF0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.