-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViewPropTypes has been removed from React Native #962
base: master
Are you sure you want to change the base?
Conversation
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
I have added new package deprecated-react-native-prop-types
can this be merged/deployed? |
Please, can we merge this branch and include it in an official release? We are dependent on this lib in our project, and we can't proceed with the upgrade to ReactNative 0.70 due to this ViewPropTypes dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a new version for deprecated-react-native-prop-types you can change it to the new version
"deprecated-react-native-prop-types": "^3.0.1",
Hello, could you merge this PR in the master and make a new tagged version, thx |
👍 to merge this PR and publish a new version 🙏 This is completely blocking for RN 0.69 |
Why it's still not merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@meliorence please, merge it when you get a chance. |
Use React Native New Snap Carousel |
It might be safe to say there's no future for this current package. It seems to have taken eons to merge and publish something that's already been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Platforms affected
ViewPropTypes has been removed from React Native.
What does this PR do?
Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
What testing has been done on this change?
Tested features checklist
enableMomentum
)vertical
)activeSlideAlignment
)autoplay
)loop
)ScrollView
/FlatList
carousels (propuseScrollView
)ParallaxImage
componentPagination
component