IMPROV: Strassesn's multiplication method #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Multiplication using strassen's algorithm. - trying to close melonjs#1181
Added fastMul() method
|
that was fast ! I'll try tomorrow :) Looking at the implementation it is longer than a regular multiplication though, makes me wonder if it actually faster, I'll let you know tomorrow anyway, I'll do some benchmark ! |
obiot
reviewed
Jul 16, 2023
| let a = this.val; | ||
| let b = m.val; | ||
|
|
||
| const A11 = [a[0], a[1], a[4], a[5]]; |
There was a problem hiding this comment.
Is there a way to do the same without creating temporary arrays?
You're right! its taking the same amount of time. (sometimes even longer)I will try to figure out a way to optimize it. Let me know if you have any ideas (This is new for me). 🥲 |
|
@sudarshanmg did you find the time to look at how to optimise it ? if not I will close this PR for now. Feel free to reopen one if you find a way to do it ? thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastMul()method that uses Strassen's algorithm