-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add a test workflow #679
Conversation
01add69
to
244bb99
Compare
837c576
to
3132214
Compare
3132214
to
82b08e2
Compare
b429b13
to
999e10b
Compare
94c2602
to
85ae491
Compare
9b9fbce
to
ef6b2bc
Compare
944cd93
to
751fd9e
Compare
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage ? 85.18%
=======================================
Files ? 34
Lines ? 3361
Branches ? 0
=======================================
Hits ? 2863
Misses ? 498
Partials ? 0 Continue to review full report at Codecov.
|
685ad1f
to
c846247
Compare
202a8e2
to
ff7e13f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this quick pass!
One failing CI test and then this is ready to go. Thanks!
I love the codecov display - thanks for that!
Yup, that's the external tests that need some credentials. |
Do I need to take some action for that? |
@aaronsteers yup, any secrets used in the GitLab CI job should be copied to https://github.com/meltano/sdk/settings/secrets/actions |
Secrets are now created as organization secrets, shared with this repo and present at the link above. I've temporarily removed the @edgarrmondragon - can we merge for now and handle the follow-up in #683 ? |
Sure 👍 |
This is the first PR in a series to migrate CI jobs from GitLab CI to GitHub Actions.
Checks run:
tests/core
,tests/cookiecutters
) on all supported Python versionstests/external
). Requires setting up secrets.For unit and external tests, coverage is computed and later combined and uploaded to Codecov in the
coverage
job.This PR also adds dependabot updates for Python tools used in CI (
poetry
,pip
) and third-party GitHub actions.Closes #680