Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a test workflow #679

Merged
merged 23 commits into from
Jun 1, 2022
Merged

chore: Add a test workflow #679

merged 23 commits into from
Jun 1, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 30, 2022

This is the first PR in a series to migrate CI jobs from GitLab CI to GitHub Actions.

Checks run:

  • Unit tests (tests/core, tests/cookiecutters) on all supported Python versions
  • External tests (tests/external). Requires setting up secrets.
  • Doctests
  • Lint

For unit and external tests, coverage is computed and later combined and uploaded to Codecov in the coverage job.

This PR also adds dependabot updates for Python tools used in CI (poetry, pip) and third-party GitHub actions.

Closes #680

@edgarrmondragon edgarrmondragon self-assigned this May 30, 2022
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 30, 2022 15:26
tox.ini Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@050f604). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage        ?   85.18%           
=======================================
  Files           ?       34           
  Lines           ?     3361           
  Branches        ?        0           
=======================================
  Hits            ?     2863           
  Misses          ?      498           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050f604...c846247. Read the comment docs.

Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this quick pass!

One failing CI test and then this is ready to go. Thanks!

I love the codecov display - thanks for that!

@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented May 31, 2022

@aaronsteers

One failing CI test and then this is ready to go. Thanks!

Yup, that's the external tests that need some credentials.

@aaronsteers
Copy link
Contributor

Yup, that's the external tests that need some credentials.

Do I need to take some action for that?

@edgarrmondragon
Copy link
Collaborator Author

Do I need to take some action for that?

@aaronsteers yup, any secrets used in the GitLab CI job should be copied to https://github.com/meltano/sdk/settings/secrets/actions

@aaronsteers
Copy link
Contributor

Do I need to take some action for that?

@aaronsteers yup, any secrets used in the GitLab CI job should be copied to https://github.com/meltano/sdk/settings/secrets/actions

Secrets are now created as organization secrets, shared with this repo and present at the link above.

I've temporarily removed the external item from the matrix so this can pass.

@edgarrmondragon - can we merge for now and handle the follow-up in #683 ?

@edgarrmondragon
Copy link
Collaborator Author

@aaronsteers

can we merge for now and handle the follow-up in #683 ?

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate GitLab CI tests to GitHub Actions
3 participants