Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POTENTIAL BREAKING CHANGE]: upgrading to aws sdk v3 and supporting sso configuration #82

Merged
merged 4 commits into from
Oct 16, 2024
+1,739 −1,097
Merged

[POTENTIAL BREAKING CHANGE]: upgrading to aws sdk v3 and supporting sso configuration #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cc3030
upgrading to aws sdk v3 and supporting sso configuration
rajeshsusai Oct 15, 2024
5c41805
pull build pipeline changes from master
rajeshsusai Oct 16, 2024
d33f78d
remove support for gallium
rajeshsusai Oct 16, 2024
2a47966
update readme
rajeshsusai Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 0 additions & 113 deletions .eslintrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# awsudo

[![Build Status](https://cloud.drone.io/api/badges/meltwater/awsudo/status.svg)](https://cloud.drone.io/meltwater/awsudo)
[![Node.js CI test](https://github.com/meltwater/awsudo/actions/workflows/nodejs.yml/badge.svg?branch=master)](https://github.com/meltwater/awsudo/actions/workflows/nodejs.yml)

A simple utility for easily executing AWS cli commands with an assumed role.

Expand Down Expand Up @@ -193,7 +193,7 @@ deploy into AWS:

```yaml
deploy:
image: awsudo/awsudo:gallium
image: awsudo/awsudo:iron
commands:
# Copy build artifacts to publicly-readable S3 bucket
- awsudo arn:aws:iam::${AWS_ACCOUNT_ID}:role/S3Access aws s3 cp ./build s3://some-bucket --acl public-read --recursive
Expand Down
4 changes: 2 additions & 2 deletions docs/architecture/ADR_001_Latest_aws_and_nodejs_in_Docker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ Docker images are often the basis of other images which rely on OS features (e.g
* Docker images are tagged to specify
* awsudo version
* nodejs version (by LTS codename)
* Ex: `:v1.7.2-gallium`
* Ex: `:v1.7.2-iron`
* Unspecified tag values "slide" to the latest version
* Ex: these tags would be equivalent:
* `:v1.7.2`
* `:gallium`
* `:iron`
* `:latest`
* Docker images are produced for every nodejs version until their [end-of-life][nodejs releases]
* The most recent `aws` version (at build time) is included
Expand Down
166 changes: 166 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
import js from '@eslint/js';
import depend from 'eslint-plugin-depend';
import jsdoc from 'eslint-plugin-jsdoc';
import globals from 'globals';

export default [
jsdoc.configs['flat/recommended'],
depend.configs['flat/recommended'],
// http://eslint.org/docs/rules/
{
languageOptions: {
ecmaVersion: 13,
sourceType: 'module',
globals: {
...globals.browser,
...globals.amd,
...globals.jasmine,
...globals.jest,
...globals.es2015,
...globals.node
}
}
},
{
ignores: [
'**/*.test.js',
'**/*.spec.js',
'**/*.config.js'
],
rules: {
...js.configs.recommended.rules,
'default-case': 'error',
'id-length': [
'error',
{
min: 2,
exceptions: ['id']
}
],
'no-alert': 'error',
'no-duplicate-imports': 'error',
'no-implicit-coercion': 'error',
'no-implied-eval': 'error',
'no-invalid-this': 'error',
'no-labels': 'error',
'no-lone-blocks': 'error',
'no-loop-func': 'error',
'no-magic-numbers': [
'error',
{
ignore: [-1, 0, 1, 2]
}
],
'no-param-reassign': 'error',
'no-prototype-builtins': 0,
'no-return-assign': ['error', 'always'],
'no-script-url': 'error',
'no-self-compare': 'error',
'no-sequences': 'error',
'no-throw-literal': 'error',
'no-unmodified-loop-condition': 'error',
'no-unused-expressions': 'error',
'no-useless-call': 'error',
'no-useless-concat': 'error',
'no-useless-return': 'error',
'no-void': 'error',
'no-with': 'error',

/**
* Stylistic rules
*/

camelcase: 'error',
'comma-dangle': [
'error',
'never'
],
complexity: 'error',
curly: [
'error',
'all'
],
indent: [
'error',
4, // http://eslint.org/docs/rules/indent
{
SwitchCase: 1
}
],
'max-depth': [
'error',
3 // http://eslint.org/docs/rules/max-depth
],
'new-cap': 'error',
'new-parens': 'error',
'no-continue': 'error',
'no-lonely-if': 'error',
'no-multiple-empty-lines': [
'error',
{
max: 1
}
],
'no-nested-ternary': 'error',
'no-tabs': 'error',
'no-trailing-spaces': [
'error',
{
ignoreComments: true,
skipBlankLines: true
}
],
'no-unneeded-ternary': 'error',
'no-unused-private-class-members': 'off',
'no-unused-vars': ['error', {
'vars': 'all',
'args': 'all',
'argsIgnorePattern': '^__',
'varsIgnorePattern': '^__',
'caughtErrorsIgnorePattern': '^__'
}],
'nonblock-statement-body-position': [
'error',
'beside' // http://eslint.org/docs/rules/nonblock-statement-body-position
],
'one-var-declaration-per-line': [
'error',
'always'
],
quotes: [
'error',
'single'
],
semi: [
'error',
'always'
],
'vars-on-top': 'error',

/**
* Depend Rules
*/
'depend/ban-dependencies': 'warn',

/**
* JSdoc Rules
*/
'jsdoc/require-jsdoc': 'off',
'jsdoc/tag-lines': 'off',

/**
* ES6 Specific
*/

'arrow-body-style': [
'error',
'as-needed'
],
'no-confusing-arrow': 'error',
'no-useless-constructor': 'error',
'no-var': 'error',
'prefer-const': 'error',
'prefer-template': 'error'
}
}
];
Loading