Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for GitLab provider #53

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SimonVHB
Copy link

Added support for GitLab provider. Seems to be working fine.

TODO: add unit tests

@SimonVHB SimonVHB changed the title Add support for GitLab provider WIP: Add support for GitLab provider Apr 29, 2021
@jimsheldon
Copy link

Hello @SimonVHB thanks for the contribution!

Please consider adding tests, let me know if you need help writing them.

@jimsheldon
Copy link

Hello again @SimonVHB

We've been putting more effort into adding support for other providers, do you still have a use case for this plugin with GitLab?

@SimonVHB
Copy link
Author

Hi @jimsheldon
Yes! We are actively using this at the moment in our drone setup actually.

I've been slacking a bit on writing the tests for this sorry

@jimsheldon
Copy link

Glad to hear it! Some of the structures will be changing soon, which will require further changes to this PR. I will reach out once things have settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants