Handle media attribute parsing without trailing new lines

membraneframework · Mar 11, 2024 · 3eb5f67 · 3eb5f67
1 parent ea367eb
commit 3eb5f67
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/lib/ex_sdp/media.ex b/lib/ex_sdp/media.ex
@@ -103,6 +103,8 @@ defmodule ExSDP.Media do
   @spec parse_optional([binary()], t()) :: {:ok, {[binary()], t()}} | {:error, atom()}
   def parse_optional(lines, media)
 
+  def parse_optional([], media), do: {:ok, {[""], finalize_optional_parsing(media)}}
+
   def parse_optional([""], media), do: {:ok, {[""], finalize_optional_parsing(media)}}
 
   def parse_optional(["" | rest], media),

diff --git a/test/ex_sdp/media_test.exs b/test/ex_sdp/media_test.exs
@@ -88,6 +88,47 @@ defmodule ExSDP.MediaTest do
                type: :audio
              } == medium
     end
+
+    test "processes audio with attributes without trailing newlines" do
+      media = "audio 58712 UDP/TLS/RTP/SAVPF 111"
+
+      attributes =
+        """
+        a=rtpmap:111 OPUS/48000/2
+        a=fmtp:111 minptime=10;maxaveragebitrate=96000;stereo=1;sprop-stereo=1;useinbandfec=1
+        """
+        |> String.split("\n", trim: true)
+
+      parsed_attributes = [
+        %Attribute.RTPMapping{
+          clock_rate: 48000,
+          encoding: "OPUS",
+          params: 2,
+          payload_type: 111
+        },
+        %Attribute.FMTP{
+          pt: 111,
+          minptime: 10,
+          maxaveragebitrate: 96000,
+          stereo: true,
+          useinbandfec: true,
+          unknown: ["sprop-stereo=1"]
+        }
+      ]
+
+      {:ok, {[""], medium}} =
+        media
+        |> Media.parse()
+        ~> ({:ok, medium} -> Media.parse_optional(attributes, medium))
+
+      assert %Media{
+               attributes: parsed_attributes,
+               fmt: ~c"o",
+               port: 58712,
+               protocol: "UDP/TLS/RTP/SAVPF",
+               type: :audio
+             } == medium
+    end
   end
 
   describe "Session property inheritance mechanism" do