Add delete_attribute(s)/2. Move attributes API to the ExSDP module. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
commented
Dec 13, 2023
lib/ex_sdp/media.ex
Outdated
Comment on lines
80
to
84
| @spec delete_attribute(media :: t(), key :: module() | atom() | binary()) :: t() | ||
| def delete_attribute(media, key), do: Utils.delete_attribute(media, key) | ||
|
|
||
| @spec delete_attributes(media :: t(), [key :: module() | atom() | binary()]) :: t() | ||
| def delete_attributes(media, keys), do: Utils.delete_attributes(media, keys) |
There was a problem hiding this comment.
I wonder if we should instead put everything in ExSDP and instead of distinguisng between ExSDP.add/get/delete_attribute and ExSDP.Media.add/get/delete_attribute, always have ExSDP.add/get/delete_attribute 🤔
There was a problem hiding this comment.
imo yes, in general the distinction between ExSDP.get_attribute() and ExSDP.Media.get_attribute() is weird and prone to mistakes.
LVala
approved these changes
Dec 14, 2023
lib/ex_sdp/media.ex
Outdated
Comment on lines
80
to
84
| @spec delete_attribute(media :: t(), key :: module() | atom() | binary()) :: t() | ||
| def delete_attribute(media, key), do: Utils.delete_attribute(media, key) | ||
|
|
||
| @spec delete_attributes(media :: t(), [key :: module() | atom() | binary()]) :: t() | ||
| def delete_attributes(media, keys), do: Utils.delete_attributes(media, keys) |
There was a problem hiding this comment.
imo yes, in general the distinction between ExSDP.get_attribute() and ExSDP.Media.get_attribute() is weird and prone to mistakes.
sgfn
approved these changes
Dec 14, 2023
mickel8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.