Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TIAS bandwidth type #43

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add TIAS bandwidth type #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc4d26
Add TIAS bandwidth type
Nov 9, 2023
bb7a04a
Update test/ex_sdp/bandwidth_test.exs
mat-hek Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ex_sdp/bandwidth.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ defmodule ExSDP.Bandwidth do
bandwidth: non_neg_integer()
}

@type type :: :CT | :AS
@type type :: :CT | :AS | :TIAS

@supported_types ["CT", "AS"]
@supported_types ["CT", "AS", "TIAS"]

@spec parse(binary()) :: {:ok, t()} | {:error, :invalid_bandwidth}
def parse(bandwidth) do
Expand Down
5 changes: 5 additions & 0 deletions test/ex_sdp/bandwidth_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ defmodule ExSDP.BandwidthTest do
assert %Bandwidth{type: :CT, bandwidth: 128} == result
end

test "parse TIAS bandwidth type" do
assert {:ok, result} = Bandwidth.parse("TIAS:256000")
assert %Bandwidth{type: :TIAS, bandwidth: 256_000} == result
end

test "returns error when property is invalid" do
assert {:error, :invalid_bandwidth} == Bandwidth.parse("gibberish")
end
Expand Down