Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AAC fmtp #52

Merged
merged 4 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The package can be installed by adding `ex_sdp` to your list of dependencies in
```elixir
def deps do
[
{:ex_sdp, "~> 1.0"}
{:ex_sdp, "~> 1.1"}
]
end
```
Expand Down
118 changes: 116 additions & 2 deletions lib/ex_sdp/attribute/fmtp.ex
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ defmodule ExSDP.Attribute.FMTP do
* Telephone Events (RFC 4733)
* RED (RFC 2198)
* G.722.1 (RFC 5577)

* AAC (RFC 3640)
are currently supported.
"""

Expand Down Expand Up @@ -71,6 +71,23 @@ defmodule ExSDP.Attribute.FMTP do
:redundant_payloads,
# G7221
:bitrate,
# AAC
:streamtype,
:config,
:mode,
:objecttype,
:constantsize,
:constantduration,
:maxdisplacement,
:de_interleavebuffersize,
:sizelength,
:indexlength,
:indexdeltalength,
:ctsdeltalength,
:dtsdeltalength,
:randomaccessindication,
:streamstateindication,
:auxillarydatasizelength,
unknown: []
]

Expand Down Expand Up @@ -121,6 +138,23 @@ defmodule ExSDP.Attribute.FMTP do
redundant_payloads: [RTPMapping.payload_type_t()] | nil,
# G7221
bitrate: non_neg_integer() | nil,
# AAC
streamtype: non_neg_integer() | nil,
config: binary() | nil,
mode: :generic | :CELP_cbr | :CELP_vbr | :AAC_lbr | :AAC_hbr | nil,
objecttype: non_neg_integer() | nil,
constantsize: non_neg_integer() | nil,
constantduration: non_neg_integer() | nil,
maxdisplacement: non_neg_integer() | nil,
de_interleavebuffersize: non_neg_integer() | nil,
sizelength: non_neg_integer() | nil,
indexlength: non_neg_integer() | nil,
indexdeltalength: non_neg_integer() | nil,
ctsdeltalength: non_neg_integer() | nil,
dtsdeltalength: non_neg_integer() | nil,
randomaccessindication: boolean() | nil,
streamstateindication: non_neg_integer() | nil,
auxillarydatasizelength: non_neg_integer() | nil,
# params that are currently not supported
unknown: [String.t()]
}
Expand Down Expand Up @@ -152,7 +186,7 @@ defmodule ExSDP.Attribute.FMTP do
|> Enum.map(&String.trim(&1))
|> do_parse(%__MODULE__{pt: pt})
else
fmtp: _other -> :invalid_fmtp
fmtp: _other -> {:error, :invalid_fmtp}
pt: {:error, _reason} = err -> err
end
end
Expand Down Expand Up @@ -336,6 +370,86 @@ defmodule ExSDP.Attribute.FMTP do
with {:ok, value} <- Utils.parse_numeric_string(value), do: {rest, %{fmtp | bitrate: value}}
end

defp parse_param(["streamtype=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | streamtype: value}}
end

defp parse_param(["config=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_config(value),
do: {rest, %{fmtp | config: value}}
end

defp parse_param(["mode=" <> value | rest], fmtp) do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: are those field names guaranteed to be unique? (By which I mean - is it guaranteed, that there is no other RFC, that adds mode field for fmtp parameter)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, even in this PR this is visible. The RFC3640 specifies a profile-level-id, but such a field is already defined in H264 section in the struct, so I don't think we need a separate one.

with {:ok, value} <- Utils.parse_mode(value),
do: {rest, %{fmtp | mode: value}}
end

defp parse_param(["objecttype=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | objecttype: value}}
end

defp parse_param(["constantsize=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | constantsize: value}}
end

defp parse_param(["constantduration=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | constantduration: value}}
end

defp parse_param(["maxdisplacement=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | maxdisplacement: value}}
end

defp parse_param(["de-interleavebuffersize=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | de_interleavebuffersize: value}}
end

defp parse_param(["sizelength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | sizelength: value}}
end

defp parse_param(["indexlength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | indexlength: value}}
end

defp parse_param(["indexdeltalength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | indexdeltalength: value}}
end

defp parse_param(["ctsdeltalength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | ctsdeltalength: value}}
end

defp parse_param(["dtsdeltalength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | dtsdeltalength: value}}
end

defp parse_param(["randomaccessindication=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_bool_string(value),
do: {rest, %{fmtp | randomaccessindication: value}}
end

defp parse_param(["streamstateindication=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | streamstateindication: value}}
end

defp parse_param(["auxillarydatasizelength=" <> value | rest], fmtp) do
with {:ok, value} <- Utils.parse_numeric_string(value),
do: {rest, %{fmtp | auxillarydatasizelength: value}}
end

defp parse_param([head | rest] = params, fmtp) do
# this is for non-key-value parameters as `key=value` format is not mandatory
cond do
Expand Down
21 changes: 21 additions & 0 deletions lib/ex_sdp/utils.ex
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,25 @@ defmodule ExSDP.Utils do
end
end)
end

@spec parse_mode(binary()) ::
{:error, :invalid_mode} | {:ok, :generic | :CELP_cbr | :CELP_vbr | :AAC_lbr | :AAC_hbr}
def parse_mode(mode_string) do
case mode_string do
"generic" -> {:ok, :generic}
"CELP-cbr" -> {:ok, :CELP_cbr}
"CELP-vbr" -> {:ok, :CELP_vbr}
"AAC-lbr" -> {:ok, :AAC_lbr}
"AAC-hbr" -> {:ok, :AAC_hbr}
_other -> {:error, :invalid_mode}
end
end

@spec parse_config(binary()) :: {:error, :invalid_config} | {:ok, binary()}
def parse_config(config_string) do
case Base.decode16(config_string) do
{:ok, config} -> {:ok, config}
:error -> {:error, :invalid_config}
end
end
end
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule ExSDP.MixProject do
use Mix.Project

@version "1.0.1"
@version "1.1.0"
@github_url "https://github.com/membraneframework/ex_sdp"

def project do
Expand Down