Add ability to specify Agora's SDK build URL #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework/membrane_agora_plugin into configurable_sdk_url
mat-hek
approved these changes
Dec 8, 2023
Comment on lines
+16
to
+31
| url = case get_target() do | ||
| %{os: "linux", architecture: "x86_64"} -> | ||
| "https://download.agora.io/sdk/release/Agora-RTC-x86_64-linux-gnu-v3.8.202.20-20220627_152601-214165.tgz" | ||
|
|
||
| other_target -> | ||
| IO.warn("Agora's Server Gateway SDK is unavailable for this target: #{inspect(other_target)}") | ||
| url = System.get_env("AGORA_SDK_URL") | ||
| if url do | ||
| url | ||
| else | ||
| IO.warn(""" | ||
| Agora's Server Gateway SDK build location unknown for target #{inspect(other_target)}. | ||
| You can pass the URL as AGORA_SDK_URL environmental variable. | ||
| """) | ||
| "" | ||
| end | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
AGORA_SDK_URLenvironmental variable